trizz/adventofcode
0
0
Fork 0
Code Issues Pull Requests Actions Releases Activity

Update dependency rector/rector to ^0.19 #9

Merged
trizz merged 1 commits from renovate/rector-rector-0.x into main 2024-06-27 13:43:21 +02:00
Conversation 0 Commits 1 Files Changed 2 +9 -9
renovate commented 2024-06-27 05:01:09 +02:00
Collaborator
Copy Link

This PR contains the following updates:

Package Type Update Change
rector/rector (source) require-dev minor ^0.18 -> ^0.19

Release Notes

rectorphp/rector (rector/rector)

v0.19.8: Released Rector 0.19.8

Compare Source

New Features 🥳

  • [experimental] Add withTypeCoverageLevel() method to streamline Rector integration to new projects (#​5553)

Bugfixes 🐛

  • Cache null result on ProjectComposerJsonPhpVersionResolver (#​5559)
  • Real fix paths The given paths do not match any files on RectorConfigBuilder (#​5561)

v0.19.7: Released Rector 0.19.7

Compare Source

Bugfixes 🐛

  • [TypeDeclaration] Skip assign in construct with method call property same name on RestoreDefaultNullToNullableTypePropertyRector (#​5556)
  • [Privatization] Fix reprint with attribute on FinalizeTestCaseClassRector (#​5557)
  • [DX] Fix missing Rector\RectorGenerator\Exception\ConfigurationException (#​5558)
  • Fix platform version resolution, use require first (#​5555)
  • bump template version (02a088c735)

v0.19.6: Released Rector 0.19.6

Compare Source

New Features and Changes 🥳

  • [EarlyReturn] Improve RemoveAlwaysElseRector to handle multiple ElseIfs (#​8178) (#​5521), Thanks @​pkvach!
  • [Privatization] Add FinalizeTestCaseClassRector (#​5539)
  • Add support for YieldFrom into places where Yield_ is checked (#​5499), Thanks @​integer!
  • [Transform] Add RectorConfigBuilderRector (#​5551)
  • [DX] Warn about run on /vendor directory (#​5525)
  • [DX] PHP sets should not disable all other version-based rules (#​5527)
  • [stabilize] Deprecate FinalizeClassesWithoutChildrenRector as causing bugs without full context (#​5535)

Bugfixes 🐛

  • Fix xdebug handling (#​5544), Thanks @​staabm!
  • Added 4 methods into RectorConfigBuilder (#​5524), Thanks @​Perf!
  • Fix AddMethodCallBasedStrictParamTypeRector if already has a type (#​5530)
  • [CodingStyle] Return null on no change on StrictArraySearchRector (#​5528)
  • [Php81] Allow nullable union on NullToStrictStringFuncCallArgRector (#​5532)
  • [stabilize] Deprecate FinalizePublicClassConstantRector as not reliable and causes uncontroller changed (#​5534)
  • [TypeDeclaration] Change bool to false or true docblock when union has false/true standalone type on ReturnUnionTypeRector (#​5543)
  • [EarlyReturn] Skip append variable in PreparedValueToEarlyReturnRector (#​8390) (#​5545), Thanks @​pkvach!
  • Fix make ReadOnlyPropertyRector skip if traits are used, as not reliable (#​5548)
  • Kick off basic rector.php with simpler and more practical rule (#​5552)

Removed 💀

  • Exclude finalize rule from private set, to keep safer (#​5523)
  • [Performance] Remove CollectedData on ProcessResult (#​5520)
  • [stabilize] Remove family tree check from ClassMethodParamVendorLockResolver as not reliable (#​5536)
  • [stabilize] Remove child classes from MixedTypeRector as not reliable (#​5537)
  • [stabilize] Remove last children method checks (#​5538)

v0.19.5: Released Rector 0.19.5

Compare Source

New Features 🎉

  • [Autoloading] Allow to define bootstrapFiles([DIR . '/some.phar']) on BootstrapFilesIncluder (#​5518)
  • add withPhpSets() methods (#​5519)

v0.19.4: Released Rector 0.19.4

Compare Source

Bugfixes 🐛

v0.19.3: Released Rector 0.19.3

Compare Source

New Features ahd Changes 🥳

  • [Config] Add RectorConfigBuilder (#​5503)
  • Add gitlab to "setup-ci" command (#​5497)
  • Add "custom-rule" command to make creating rules easy (#​5498)
  • [Windows] Rework add windows support on tests CI (#​5504)
  • make literal separator optional, as rather coding style and not always desired (#​5505)

Bugfixes 🐛

  • [Php70] Skip inside Encapsed on ThisCallOnStaticMethodToStaticCallRector (#​5481)
  • [Performance] Cache PHP version features on reading composer.json on PhpVersionProvider (#​5484)
  • Fix phpstan (#​5489)
  • [Config] Restore default values for RectorConfig->parallel() config similar to original <=0.18.x version (#​5472)
  • [Performance][PhpParser] Deprecate InlineCodeParser::parse(), extract into parseFile() and parseString() (#​5482)
  • [CodeQuality] Skip surplus open square bracket on SimplifyRegexPatternRector (#​5494)
  • [AutoImport] Skip start with <?= short open tag on auto import (#​5496)
  • [Testing] Deprecate FileInfoParser, use existing TestingParser instead (#​5501)
  • custom copy path fix (#​5502)
  • [DX] Allow Arg in value resolver, as often used and intuitive (#​5512)
  • [Windows] Support replace \r\n on DocBlockInliner (#​5513)
  • [Php83] add string type to concat constant (#​5516), Thanks @​jdohuutin!

Removed 💀

  • [Renaming] Remove namespace renames in ClassRename, as it should only rename references, not move to new namespace (#​5487)
  • [Renaming] Remove rename class name (#​5488)

v0.19.2: Released Rector 0.19.2

Compare Source

New features and Changes 🎉

  • [DX] Depreate heavy and conflicting Symfony/Twig/PHPUnit level sets (#​5477)
  • Remove collectors, as performance very costly and not practically useful (#​5470)

Bugfixes 🐛


Removed 💀

  • [Performance] Remove unused AttributeKey::ARGUMENT_POSITION (#​5469)
  • [Autoload] Remove src/core_namespace_aliases.php (#​5476)

v0.19.1

Compare Source

v0.19.0: Released Rector 0.19.0

Compare Source

In this release we merged 2 directories into /src to speed up class loading and make work with code easier. This leads to BC change in namespace for your custom rules:

-use Rector\Core\
+use Rector\

That's it!

New Features 🥳

  • [psr-4] Move /packages directory to /src under single Rector\ namespace (#​5414)
  • [Arguments] Allow no default value on ArgumentAdderRector (#​5382)
  • Add related polyfill interface to other PHP 8.0/7.3 rules (#​5389)
  • [CodingStyle] Add RemoveUselessAliasInUseStatementRector (#​5394)
  • [Php83] Add CombineHostPortLdapUriRector (#​5397)
  • [TypeDeclaration] optionally only add types for hard coded return values in ReturnTypeFromStrictScalarReturnExprRector (#​5364), Thanks @​RobertMe!
  • Add phpstan native cond types for getName() for nodes that always return a string (#​5413)
  • [Strict] Add StaticProperty supporton may be unitialized static property on DisallowedEmptyRuleFixerRector (#​5428)
  • [Php83] Add implements interface support on AddOverrideAttributeToOverriddenMethodsRector (#​5429)
  • [cs] Make use of new ECS config (#​5445)

Bugfixes 🐛

  • [TypeDeclaration] Add false and true in union support on ReturnUnionTypeRector (#​5355)
  • Skip classes without final and exception as possibly invoke child implement in AddVoidReturnTypeWhereNoReturnRector (#​5381)
  • Skip non-final class method with no content in AddVoidReturnTypeWhereNoReturnRector (#​5386)
  • [TypeDeclaration] Allow add void return type on magic __invoke() method on AddVoidReturnTypeWhereNoReturnRector (#​5376)
  • Add ReturnTypeFromStrictBoolReturnExprRector support for if/else returns (#​5384)
  • Skip void without final keyword in ReturnNeverTypeRector as could be implemented with more precise children (#​5379)
  • Fix StrictArrayParamDimFetchRector for string access (#​5383)
  • Fix variable to property fetch update in ClassPropertyAssignToConstructorPromotionRector (#​5385)
  • [Php] Fix filter cache on PolyfillPackagesProvider (#​5390)
  • [Parallel] Fix missing --xdebug in WorkerCommand line on WorkerCommandLineFactory when --xdebug provided (#​5398)
  • Bump phpstan to 1.10.50 (#​5399)
  • [Php83] Handle dynamic host and port values on CombineHostPortLdapUriRector (#​5401)
  • [config] Extract RectorConfigValidator and handle config validation there (#​5404)
  • [psr-4] Update Rector core test reference (#​5410)
  • [cleanup] Decouple changelog generator (#​5412)
  • [Strict] Handle may be unitialized property on DisallowedEmptyRuleFixerRector (#​5409)
  • Bump min. version to PHP 8.2 - readonly classes (#​5415)
  • Decouple LongAndDependentComplexRectorRule to cognitive-complexity package (#​5427)
  • [TypeDeclaration] Skip with empty() check on StrictArrayParamDimFetchRector (#​5432)
  • [TypeDeclaration] Allow both integer and string index array on StrictArrayParamDimFetchRector (#​5433)
  • [TypeDeclaration] Skip re-assign with call and use as arg on StrictArrayParamDimFetchRector (#​5434)
  • [CodeQuality] Handle crash with call inside loop on SimplifyForeachToCoalescingRector (#​5436)
  • [TypeDeclaration] Handle with default null on ParamTypeByMethodCallTypeRector (#​5437)
  • [NodeTypeResolver] Handle crash PHPStan\File\CouldNotReadFileException: Could not read file on IntermediateSourceLocator (#​5438)
  • Allows to convert Spatie enum names to snake upper case (#​5435), Thanks @​JoolsMcFly!
  • fix: RenameMethodRector should handle NullsafeMethodCall (#​5444), Thanks @​nikophil!
  • [Php80][CodeQuality] Handle crash on ChangeSwitchToMatchRector + TernaryFalseExpressionToIfRector on under if else (#​5446)
  • Skip cond with side effect in RemoveDeadConditionAboveReturnRector (#​5424)
  • [DeadCode] Skip nullable array on RemoveUnusedNonEmptyArrayBeforeForeachRector (#​5375)
  • Keep called method in RemoveEmptyClassMethodRector (#​5425)

Removed 💀

  • [DeadCode] Remove RemoveJustPropertyFetchForAssignRector as tailored for single case of private project, not practical for generic use (#​5418)
  • remove array spread from coding style, as often part of personal preference (a326b8504d)

v0.18.13: Released Rector 0.18.13

Compare Source

New Features 🥳

  • [DeadCode] Add Function_ support on RemoveUselessReturnTagRector (#​5325)
  • [TypeDeclaration] Add MergeDateTimePropertyTypeDeclarationRector (#​5327)
  • [DeadCode] Add Function_ support on RemoveUselessParamTagRector (#​5331)
  • [DeadCode] Add RemoveNullTagValueNodeRector (#​5352)

Bugfixes 🐛

  • [Php83] Fix const from applying incorrect types (#​5326), Thanks @​peterfox!
  • [TypeDeclaration] Fix missing change type to DateTimeInterface on MergeDateTimePropertyTypeDeclarationRector (#​5329)
  • [TypeDeclaration] Handle DateTimeInterface from use statement on MergeDateTimePropertyTypeDeclarationRector (#​5330)
  • [TypeDeclaration] Handle assign $this on TypedPropertyFromAssignsRector (#​5333)
  • Fix array type if property is used in TypedPropertyFromStrictConstructorRector (#​5339)
  • [Naming] Skip DateTimeImmutable on RenamePropertyToMatchTypeRector (#​5340)
  • [PHP 7.4] Skip typed properties in the set, as standalone set now available (#​5342)
  • [TypeDeclaration] Skip has child return different type on ReturnNeverTypeRector (#​5343)
  • [Experiment][TypeDeclaration] Allow change abstract class methods with body on ReturnType*Rector (#​5344)
  • [Php55] Make StringClassNameToClassConstantRector configurable to keep first pre-backslash string configurable (#​5354)
  • [TypeDeclaration] Skip casted to (array) on StrictArrayParamDimFetchRector (#​5356)
  • [TypeDeclaration] Return new static from different object on ReturnTypeFromStrictTypedCallRector (#​5357)
  • [TypeDeclaration] Allow return static from under function on ReturnTypeFromStrictTypedCallRector (#​5358)
  • [Naming] Skip $this in RenameForeachValueVariableToMatchExprVariableRector (#​5360), Thanks @​sreichel!
  • [Transform] Do not create a new node if the existing node is already the correct one on AttributeKeyToClassConstFetchRector (#​5328), Thanks @​SerethiX!
  • Bump to php parser 4.18 (#​5362)
  • [CodeQuality] Skip Superglobals variable on SimplifyEmptyCheckOnEmptyArrayRector (#​5369)
  • [Php55] Handle crash after exit() on GetCalledClassToSelfClassRector (#​5372)
  • [CodeQuality] Skip method call on else on TernaryFalseExpressionToIfRector (#​5373)
  • Remove return type in case of never in RemoveUselessReturnTagRector (#​5323), Thanks @​staabm!
  • [DeadCode] Remove unused @​return mixed on RemoveUselessReturnTagRector (#​5332)
  • [DeadCode] Skip has parent class with __call() magic method on RemoveParentCallWithoutParentRector (#​5336)
  • [PHP 5.5] Remove extra preslash in class reference, as in practice removal manually (#​5338)
  • [DeadCode] Remove null as never used param type in RemoveUselessParamTagRector (#​5348)
  • Remove json throw on error rule from PHP 7.3 set, as changed behavior and must be applied on purpose (#​5349)
  • [Testing] Remove unnecessary set Parameter Source on TestingParser (#​5371)

v0.18.12: Released Rector 0.18.12

Compare Source

New Features 🥳

  • [CodeQuality] Add RemoveUselessIsObjectCheckRector (#​5316)
  • [PHP83] Implements a rule to add types to class constants (#​5290), Thanks @​peterfox!

Bugfixes 🐛

  • [TypeDeclaration] Skip iterable already there in AddReturnTypeDeclarationFromYieldsRector (#​5291)
  • [TypeDeclaration] Remove ParamTypeFromStrictTypedPropertyRector as seems similar feature with AddParamTypeFromPropertyTypeRector (#​5293)
  • [CodingStyle] Remove AddArrayDefaultToArrayPropertyRector as based on docblock types and public contract, better use type declaration set instad (#​5298)
  • [TypeDeclaration] Skip return void in abstract empty class in AddVoidReturnTypeWhereNoReturnRector (#​5311)
  • [Php80] Skip PDO::query() on AddParamBasedOnParentClassMethodRector (#​5313)
  • [TypeDeclaration] Add If else assign support on TypedPropertyFromAssignsRector (#​5314)
  • [CodeQuality] Make CommonNotEqualRector skip if not <> (#​5292)
  • [Naming] Skip singularize "cms" on RenameForeachValueVariableToMatchExprVariableRector (#​5294)
  • [TypeDeclaration][Performance] Check typed param already early on ParamTypeByMethodCallTypeRector (#​5295)
  • [Strict] Fix DisallowedEmptyRuleFixerRector empty() allow string '0' check (#​5296)
  • [EarlyReturn] Skip duplicating complex expression in ChangeAndIfToEarlyReturnRector (#​5301)
  • [Scoped] Exclude symfony/console/Debug/CliRequest.php from parallel-lint PHP 7.2 syntax check (#​5304)
  • Skip RenameMethodRector in never (#​5305), Thanks @​staabm!
  • [CodeQuality] Skip with else on SimplifyForeachToCoalescingRector (#​5307)
  • [Doc] Typo fix on sample code documentation on SimplifyForeachToCoalescingRector (#​5308)
  • [Privatization] Skip call non-private method on non-final class on PrivatizeLocalGetterToPropertyRector (#​5309)
  • [Privatization] Fix first class callable in PrivatizeLocalGetterToPropertyRector (#​5310)
  • [TypeDeclaration] Keep constant false return type from strict native call (#​5223), Thanks @​tomi85!
  • [PHP 7.0] Skip mt_rand() replacement as not valuable (#​5315)
  • [Strict] Allow check '0' empty zero on BooleanInTernaryOperatorRuleFixerRector on string type (#​5297)
  • Fix annotation to attribute parsing string (#​5317)
  • [Instanceof] Fix combination of dead instance and compare (#​5319)
  • Remove isPositiveInteger() check for third argument to strpos() (#​5257), Thanks @​ikari7789!
  • Remove return type in case of void in RemoveUselessReturnTagRector (#​5318)
  • [DeadCode] Skip @​return never with void on RemoveUselessReturnTagRector (#​5320)
  • [DeadCode] Remove useless nullable @​return doc on RemoveUselessReturnTagRector (#​5321)

Configuration

📅 Schedule: Branch creation - "before 7am" (UTC), Automerge - "before 7am" (UTC).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rector/rector](https://getrector.org) ([source](https://github.com/rectorphp/rector)) | require-dev | minor | `^0.18` -> `^0.19` | --- ### Release Notes <details> <summary>rectorphp/rector (rector/rector)</summary> ### [`v0.19.8`](https://github.com/rectorphp/rector/releases/tag/0.19.8): Released Rector 0.19.8 [Compare Source](https://github.com/rectorphp/rector/compare/0.19.7...0.19.8) #### New Features :partying_face: - \[experimental] Add withTypeCoverageLevel() method to streamline Rector integration to new projects ([#&#8203;5553](https://github.com/rectorphp/rector-src/pull/5553)) <br> #### Bugfixes :bug: - Cache null result on ProjectComposerJsonPhpVersionResolver ([#&#8203;5559](https://github.com/rectorphp/rector-src/pull/5559)) - Real fix paths The given paths do not match any files on RectorConfigBuilder ([#&#8203;5561](https://github.com/rectorphp/rector-src/pull/5561)) ### [`v0.19.7`](https://github.com/rectorphp/rector/releases/tag/0.19.7): Released Rector 0.19.7 [Compare Source](https://github.com/rectorphp/rector/compare/0.19.6...0.19.7) #### Bugfixes :bug: - \[TypeDeclaration] Skip assign in construct with method call property same name on RestoreDefaultNullToNullableTypePropertyRector ([#&#8203;5556](https://github.com/rectorphp/rector-src/pull/5556)) - \[Privatization] Fix reprint with attribute on FinalizeTestCaseClassRector ([#&#8203;5557](https://github.com/rectorphp/rector-src/pull/5557)) - \[DX] Fix missing Rector\RectorGenerator\Exception\ConfigurationException ([#&#8203;5558](https://github.com/rectorphp/rector-src/pull/5558)) - Fix platform version resolution, use require first ([#&#8203;5555](https://github.com/rectorphp/rector-src/pull/5555)) - bump template version (https://github.com/rectorphp/rector-src/commit/02a088c735b9b829c8f0dec445e71dea70e559bc) ### [`v0.19.6`](https://github.com/rectorphp/rector/releases/tag/0.19.6): Released Rector 0.19.6 [Compare Source](https://github.com/rectorphp/rector/compare/0.19.5...0.19.6) #### New Features and Changes :partying_face: - \[EarlyReturn] Improve RemoveAlwaysElseRector to handle multiple ElseIfs ([#&#8203;8178](https://github.com/rectorphp/rector/issues/8178)) ([#&#8203;5521](https://github.com/rectorphp/rector-src/pull/5521)), Thanks [@&#8203;pkvach](https://github.com/pkvach)! - \[Privatization] Add FinalizeTestCaseClassRector ([#&#8203;5539](https://github.com/rectorphp/rector-src/pull/5539)) - Add support for YieldFrom into places where Yield\_ is checked ([#&#8203;5499](https://github.com/rectorphp/rector-src/pull/5499)), Thanks [@&#8203;integer](https://github.com/integer)! - \[Transform] Add RectorConfigBuilderRector ([#&#8203;5551](https://github.com/rectorphp/rector-src/pull/5551)) - \[DX] Warn about run on /vendor directory ([#&#8203;5525](https://github.com/rectorphp/rector-src/pull/5525)) - \[DX] PHP sets should not disable all other version-based rules ([#&#8203;5527](https://github.com/rectorphp/rector-src/pull/5527)) - **\[stabilize] Deprecate FinalizeClassesWithoutChildrenRector as causing bugs without full context ([#&#8203;5535](https://github.com/rectorphp/rector-src/pull/5535))** <br> #### Bugfixes :bug: - **Fix xdebug handling ([#&#8203;5544](https://github.com/rectorphp/rector-src/pull/5544)), Thanks [@&#8203;staabm](https://github.com/staabm)!** - Added 4 methods into RectorConfigBuilder ([#&#8203;5524](https://github.com/rectorphp/rector-src/pull/5524)), Thanks [@&#8203;Perf](https://github.com/Perf)! - Fix AddMethodCallBasedStrictParamTypeRector if already has a type ([#&#8203;5530](https://github.com/rectorphp/rector-src/pull/5530)) - \[CodingStyle] Return null on no change on StrictArraySearchRector ([#&#8203;5528](https://github.com/rectorphp/rector-src/pull/5528)) - \[Php81] Allow nullable union on NullToStrictStringFuncCallArgRector ([#&#8203;5532](https://github.com/rectorphp/rector-src/pull/5532)) - \[stabilize] Deprecate FinalizePublicClassConstantRector as not reliable and causes uncontroller changed ([#&#8203;5534](https://github.com/rectorphp/rector-src/pull/5534)) - \[TypeDeclaration] Change bool to false or true docblock when union has false/true standalone type on ReturnUnionTypeRector ([#&#8203;5543](https://github.com/rectorphp/rector-src/pull/5543)) - \[EarlyReturn] Skip append variable in PreparedValueToEarlyReturnRector ([#&#8203;8390](https://github.com/rectorphp/rector/issues/8390)) ([#&#8203;5545](https://github.com/rectorphp/rector-src/pull/5545)), Thanks [@&#8203;pkvach](https://github.com/pkvach)! - Fix make ReadOnlyPropertyRector skip if traits are used, as not reliable ([#&#8203;5548](https://github.com/rectorphp/rector-src/pull/5548)) - Kick off basic rector.php with simpler and more practical rule ([#&#8203;5552](https://github.com/rectorphp/rector-src/pull/5552)) <br> #### Removed :skull: - Exclude finalize rule from private set, to keep safer ([#&#8203;5523](https://github.com/rectorphp/rector-src/pull/5523)) - \[Performance] Remove CollectedData on ProcessResult ([#&#8203;5520](https://github.com/rectorphp/rector-src/pull/5520)) - \[stabilize] Remove family tree check from ClassMethodParamVendorLockResolver as not reliable ([#&#8203;5536](https://github.com/rectorphp/rector-src/pull/5536)) - \[stabilize] Remove child classes from MixedTypeRector as not reliable ([#&#8203;5537](https://github.com/rectorphp/rector-src/pull/5537)) - \[stabilize] Remove last children method checks ([#&#8203;5538](https://github.com/rectorphp/rector-src/pull/5538)) ### [`v0.19.5`](https://github.com/rectorphp/rector/releases/tag/0.19.5): Released Rector 0.19.5 [Compare Source](https://github.com/rectorphp/rector/compare/0.19.4...0.19.5) #### New Features :tada: - \[Autoloading] Allow to define bootstrapFiles(\[**DIR** . '/some.phar']) on BootstrapFilesIncluder ([#&#8203;5518](https://github.com/rectorphp/rector-src/pull/5518)) - add withPhpSets() methods ([#&#8203;5519](https://github.com/rectorphp/rector-src/pull/5519)) ### [`v0.19.4`](https://github.com/rectorphp/rector/releases/tag/0.19.4): Released Rector 0.19.4 [Compare Source](https://github.com/rectorphp/rector/compare/0.19.3...0.19.4) #### Bugfixes :bug: - Fix configured rule ([#&#8203;5517](https://github.com/rectorphp/rector-src/pull/5517)) ### [`v0.19.3`](https://github.com/rectorphp/rector/releases/tag/0.19.3): Released Rector 0.19.3 [Compare Source](https://github.com/rectorphp/rector/compare/0.19.2...0.19.3) #### New Features ahd Changes :partying_face: - **\[Config] Add RectorConfigBuilder ([#&#8203;5503](https://github.com/rectorphp/rector-src/pull/5503))** - Add gitlab to "setup-ci" command ([#&#8203;5497](https://github.com/rectorphp/rector-src/pull/5497)) - **Add "custom-rule" command to make creating rules easy ([#&#8203;5498](https://github.com/rectorphp/rector-src/pull/5498))** - \[Windows] Rework add windows support on tests CI ([#&#8203;5504](https://github.com/rectorphp/rector-src/pull/5504)) - make literal separator optional, as rather coding style and not always desired ([#&#8203;5505](https://github.com/rectorphp/rector-src/pull/5505)) <br> #### Bugfixes :bug: - \[Php70] Skip inside Encapsed on ThisCallOnStaticMethodToStaticCallRector ([#&#8203;5481](https://github.com/rectorphp/rector-src/pull/5481)) - \[Performance] Cache PHP version features on reading composer.json on PhpVersionProvider ([#&#8203;5484](https://github.com/rectorphp/rector-src/pull/5484)) - Fix phpstan ([#&#8203;5489](https://github.com/rectorphp/rector-src/pull/5489)) - \[Config] Restore default values for RectorConfig->parallel() config similar to original <=0.18.x version ([#&#8203;5472](https://github.com/rectorphp/rector-src/pull/5472)) - \[Performance]\[PhpParser] Deprecate InlineCodeParser::parse(), extract into parseFile() and parseString() ([#&#8203;5482](https://github.com/rectorphp/rector-src/pull/5482)) - \[CodeQuality] Skip surplus open square bracket on SimplifyRegexPatternRector ([#&#8203;5494](https://github.com/rectorphp/rector-src/pull/5494)) - \[AutoImport] Skip start with \<?= short open tag on auto import ([#&#8203;5496](https://github.com/rectorphp/rector-src/pull/5496)) - \[Testing] Deprecate FileInfoParser, use existing TestingParser instead ([#&#8203;5501](https://github.com/rectorphp/rector-src/pull/5501)) - custom copy path fix ([#&#8203;5502](https://github.com/rectorphp/rector-src/pull/5502)) - \[DX] Allow Arg in value resolver, as often used and intuitive ([#&#8203;5512](https://github.com/rectorphp/rector-src/pull/5512)) - \[Windows] Support replace \r\n on DocBlockInliner ([#&#8203;5513](https://github.com/rectorphp/rector-src/pull/5513)) - \[Php83] add string type to concat constant ([#&#8203;5516](https://github.com/rectorphp/rector-src/pull/5516)), Thanks [@&#8203;jdohuutin](https://github.com/jdohuutin)! <br> #### Removed :skull: - \[Renaming] Remove namespace renames in ClassRename, as it should only rename references, not move to new namespace ([#&#8203;5487](https://github.com/rectorphp/rector-src/pull/5487)) - \[Renaming] Remove rename class name ([#&#8203;5488](https://github.com/rectorphp/rector-src/pull/5488)) ### [`v0.19.2`](https://github.com/rectorphp/rector/releases/tag/0.19.2): Released Rector 0.19.2 [Compare Source](https://github.com/rectorphp/rector/compare/0.19.1...0.19.2) #### New features and Changes :tada: - \[DX] Depreate heavy and conflicting Symfony/Twig/PHPUnit level sets ([#&#8203;5477](https://github.com/rectorphp/rector-src/pull/5477)) - Remove collectors, as performance very costly and not practically useful ([#&#8203;5470](https://github.com/rectorphp/rector-src/pull/5470)) <br> #### Bugfixes :bug: - **Fix repeated timeouts on CI - https://github.com/rectorphp/rector/issues/8403, https://github.com/rectorphp/rector/issues/8396** - Bump PHPStan to 1.10.56 ([#&#8203;5471](https://github.com/rectorphp/rector-src/pull/5471)) - Remove collector interface and fix SpatieEnumClassToEnumRector already has underscore to double underscore ([#&#8203;5473](https://github.com/rectorphp/rector-src/pull/5473)) - \[DX] Depreate heavy and conflicting Symfony/Twig/PHPUnit level sets ([#&#8203;5477](https://github.com/rectorphp/rector-src/pull/5477)) <br> #### Removed :skull: - \[Performance] Remove unused AttributeKey::ARGUMENT_POSITION ([#&#8203;5469](https://github.com/rectorphp/rector-src/pull/5469)) - \[Autoload] Remove src/core_namespace_aliases.php ([#&#8203;5476](https://github.com/rectorphp/rector-src/pull/5476)) ### [`v0.19.1`](https://github.com/rectorphp/rector/compare/0.19.0...0.19.1) [Compare Source](https://github.com/rectorphp/rector/compare/0.19.0...0.19.1) ### [`v0.19.0`](https://github.com/rectorphp/rector/releases/tag/0.19.0): Released Rector 0.19.0 [Compare Source](https://github.com/rectorphp/rector/compare/0.18.13...0.19.0) In this release we merged 2 directories into `/src` to speed up class loading and make work with code easier. This leads to BC change in namespace for your custom rules: ```diff -use Rector\Core\ +use Rector\ ``` That's it! #### New Features :partying_face: - \[psr-4] Move /packages directory to /src under single Rector\ namespace ([#&#8203;5414](https://github.com/rectorphp/rector-src/pull/5414)) - \[Arguments] Allow no default value on ArgumentAdderRector ([#&#8203;5382](https://github.com/rectorphp/rector-src/pull/5382)) - **Add related polyfill interface to other PHP 8.0/7.3 rules** ([#&#8203;5389](https://github.com/rectorphp/rector-src/pull/5389)) - \[CodingStyle] Add RemoveUselessAliasInUseStatementRector ([#&#8203;5394](https://github.com/rectorphp/rector-src/pull/5394)) - \[Php83] Add CombineHostPortLdapUriRector ([#&#8203;5397](https://github.com/rectorphp/rector-src/pull/5397)) - \[TypeDeclaration] optionally only add types for hard coded return values in `ReturnTypeFromStrictScalarReturnExprRector` ([#&#8203;5364](https://github.com/rectorphp/rector-src/pull/5364)), Thanks [@&#8203;RobertMe](https://github.com/RobertMe)! - Add phpstan native cond types for getName() for nodes that always return a string ([#&#8203;5413](https://github.com/rectorphp/rector-src/pull/5413)) - \[Strict] Add StaticProperty supporton may be unitialized static property on DisallowedEmptyRuleFixerRector ([#&#8203;5428](https://github.com/rectorphp/rector-src/pull/5428)) - \[Php83] Add implements interface support on AddOverrideAttributeToOverriddenMethodsRector ([#&#8203;5429](https://github.com/rectorphp/rector-src/pull/5429)) - \[cs] Make use of new ECS config ([#&#8203;5445](https://github.com/rectorphp/rector-src/pull/5445)) <br> #### Bugfixes :bug: - \[TypeDeclaration] Add false and true in union support on ReturnUnionTypeRector ([#&#8203;5355](https://github.com/rectorphp/rector-src/pull/5355)) - Skip classes without final and exception as possibly invoke child implement in AddVoidReturnTypeWhereNoReturnRector ([#&#8203;5381](https://github.com/rectorphp/rector-src/pull/5381)) - Skip non-final class method with no content in AddVoidReturnTypeWhereNoReturnRector ([#&#8203;5386](https://github.com/rectorphp/rector-src/pull/5386)) - \[TypeDeclaration] Allow add void return type on magic `__invoke()` method on AddVoidReturnTypeWhereNoReturnRector ([#&#8203;5376](https://github.com/rectorphp/rector-src/pull/5376)) - Add `ReturnTypeFromStrictBoolReturnExprRector` support for if/else returns ([#&#8203;5384](https://github.com/rectorphp/rector-src/pull/5384)) - Skip void without final keyword in ReturnNeverTypeRector as could be implemented with more precise children ([#&#8203;5379](https://github.com/rectorphp/rector-src/pull/5379)) - Fix StrictArrayParamDimFetchRector for string access ([#&#8203;5383](https://github.com/rectorphp/rector-src/pull/5383)) - Fix variable to property fetch update in ClassPropertyAssignToConstructorPromotionRector ([#&#8203;5385](https://github.com/rectorphp/rector-src/pull/5385)) - \[Php] Fix filter cache on PolyfillPackagesProvider ([#&#8203;5390](https://github.com/rectorphp/rector-src/pull/5390)) - \[Parallel] Fix missing --xdebug in WorkerCommand line on WorkerCommandLineFactory when --xdebug provided ([#&#8203;5398](https://github.com/rectorphp/rector-src/pull/5398)) - Bump phpstan to 1.10.50 ([#&#8203;5399](https://github.com/rectorphp/rector-src/pull/5399)) - \[Php83] Handle dynamic host and port values on CombineHostPortLdapUriRector ([#&#8203;5401](https://github.com/rectorphp/rector-src/pull/5401)) - \[config] Extract RectorConfigValidator and handle config validation there ([#&#8203;5404](https://github.com/rectorphp/rector-src/pull/5404)) - \[psr-4] Update Rector core test reference ([#&#8203;5410](https://github.com/rectorphp/rector-src/pull/5410)) - \[cleanup] Decouple changelog generator ([#&#8203;5412](https://github.com/rectorphp/rector-src/pull/5412)) - \[Strict] Handle may be unitialized property on DisallowedEmptyRuleFixerRector ([#&#8203;5409](https://github.com/rectorphp/rector-src/pull/5409)) - Bump min. version to PHP 8.2 - readonly classes ([#&#8203;5415](https://github.com/rectorphp/rector-src/pull/5415)) - Decouple LongAndDependentComplexRectorRule to cognitive-complexity package ([#&#8203;5427](https://github.com/rectorphp/rector-src/pull/5427)) - \[TypeDeclaration] Skip with empty() check on StrictArrayParamDimFetchRector ([#&#8203;5432](https://github.com/rectorphp/rector-src/pull/5432)) - \[TypeDeclaration] Allow both integer and string index array on StrictArrayParamDimFetchRector ([#&#8203;5433](https://github.com/rectorphp/rector-src/pull/5433)) - \[TypeDeclaration] Skip re-assign with call and use as arg on StrictArrayParamDimFetchRector ([#&#8203;5434](https://github.com/rectorphp/rector-src/pull/5434)) - \[CodeQuality] Handle crash with call inside loop on SimplifyForeachToCoalescingRector ([#&#8203;5436](https://github.com/rectorphp/rector-src/pull/5436)) - \[TypeDeclaration] Handle with default null on ParamTypeByMethodCallTypeRector ([#&#8203;5437](https://github.com/rectorphp/rector-src/pull/5437)) - \[NodeTypeResolver] Handle crash PHPStan\File\CouldNotReadFileException: Could not read file on IntermediateSourceLocator ([#&#8203;5438](https://github.com/rectorphp/rector-src/pull/5438)) - Allows to convert Spatie enum names to snake upper case ([#&#8203;5435](https://github.com/rectorphp/rector-src/pull/5435)), Thanks [@&#8203;JoolsMcFly](https://github.com/JoolsMcFly)! - fix: RenameMethodRector should handle NullsafeMethodCall ([#&#8203;5444](https://github.com/rectorphp/rector-src/pull/5444)), Thanks [@&#8203;nikophil](https://github.com/nikophil)! - \[Php80]\[CodeQuality] Handle crash on ChangeSwitchToMatchRector + TernaryFalseExpressionToIfRector on under if else ([#&#8203;5446](https://github.com/rectorphp/rector-src/pull/5446)) - Skip cond with side effect in RemoveDeadConditionAboveReturnRector ([#&#8203;5424](https://github.com/rectorphp/rector-src/pull/5424)) - \[DeadCode] Skip nullable array on RemoveUnusedNonEmptyArrayBeforeForeachRector ([#&#8203;5375](https://github.com/rectorphp/rector-src/pull/5375)) - Keep called method in RemoveEmptyClassMethodRector ([#&#8203;5425](https://github.com/rectorphp/rector-src/pull/5425)) <br> #### Removed :skull: - \[DeadCode] Remove RemoveJustPropertyFetchForAssignRector as tailored for single case of private project, not practical for generic use ([#&#8203;5418](https://github.com/rectorphp/rector-src/pull/5418)) - remove array spread from coding style, as often part of personal preference (https://github.com/rectorphp/rector-src/commit/a326b8504d37093f639245da0b283f588f954890) ### [`v0.18.13`](https://github.com/rectorphp/rector/releases/tag/0.18.13): Released Rector 0.18.13 [Compare Source](https://github.com/rectorphp/rector/compare/0.18.12...0.18.13) #### New Features :partying_face: - \[DeadCode] Add Function\_ support on RemoveUselessReturnTagRector ([#&#8203;5325](https://github.com/rectorphp/rector-src/pull/5325)) - \[TypeDeclaration] Add MergeDateTimePropertyTypeDeclarationRector ([#&#8203;5327](https://github.com/rectorphp/rector-src/pull/5327)) - \[DeadCode] Add Function\_ support on RemoveUselessParamTagRector ([#&#8203;5331](https://github.com/rectorphp/rector-src/pull/5331)) - \[DeadCode] Add RemoveNullTagValueNodeRector ([#&#8203;5352](https://github.com/rectorphp/rector-src/pull/5352)) <br> #### Bugfixes :bug: - \[Php83] Fix const from applying incorrect types ([#&#8203;5326](https://github.com/rectorphp/rector-src/pull/5326)), Thanks [@&#8203;peterfox](https://github.com/peterfox)! - \[TypeDeclaration] Fix missing change type to DateTimeInterface on MergeDateTimePropertyTypeDeclarationRector ([#&#8203;5329](https://github.com/rectorphp/rector-src/pull/5329)) - \[TypeDeclaration] Handle DateTimeInterface from use statement on MergeDateTimePropertyTypeDeclarationRector ([#&#8203;5330](https://github.com/rectorphp/rector-src/pull/5330)) - \[TypeDeclaration] Handle assign $this on TypedPropertyFromAssignsRector ([#&#8203;5333](https://github.com/rectorphp/rector-src/pull/5333)) - Fix array type if property is used in TypedPropertyFromStrictConstructorRector ([#&#8203;5339](https://github.com/rectorphp/rector-src/pull/5339)) - \[Naming] Skip DateTimeImmutable on RenamePropertyToMatchTypeRector ([#&#8203;5340](https://github.com/rectorphp/rector-src/pull/5340)) - \[PHP 7.4] Skip typed properties in the set, as standalone set now available ([#&#8203;5342](https://github.com/rectorphp/rector-src/pull/5342)) - \[TypeDeclaration] Skip has child return different type on ReturnNeverTypeRector ([#&#8203;5343](https://github.com/rectorphp/rector-src/pull/5343)) - \[Experiment]\[TypeDeclaration] Allow change abstract class methods with body on ReturnType\*Rector ([#&#8203;5344](https://github.com/rectorphp/rector-src/pull/5344)) - \[Php55] Make StringClassNameToClassConstantRector configurable to keep first pre-backslash string configurable ([#&#8203;5354](https://github.com/rectorphp/rector-src/pull/5354)) - \[TypeDeclaration] Skip casted to (array) on StrictArrayParamDimFetchRector ([#&#8203;5356](https://github.com/rectorphp/rector-src/pull/5356)) - \[TypeDeclaration] Return new static from different object on ReturnTypeFromStrictTypedCallRector ([#&#8203;5357](https://github.com/rectorphp/rector-src/pull/5357)) - \[TypeDeclaration] Allow return static from under function on ReturnTypeFromStrictTypedCallRector ([#&#8203;5358](https://github.com/rectorphp/rector-src/pull/5358)) - \[Naming] Skip `$this` in RenameForeachValueVariableToMatchExprVariableRector ([#&#8203;5360](https://github.com/rectorphp/rector-src/pull/5360)), Thanks [@&#8203;sreichel](https://github.com/sreichel)! - \[Transform] Do not create a new node if the existing node is already the correct one on AttributeKeyToClassConstFetchRector ([#&#8203;5328](https://github.com/rectorphp/rector-src/pull/5328)), Thanks [@&#8203;SerethiX](https://github.com/SerethiX)! - Bump to php parser 4.18 ([#&#8203;5362](https://github.com/rectorphp/rector-src/pull/5362)) - \[CodeQuality] Skip Superglobals variable on SimplifyEmptyCheckOnEmptyArrayRector ([#&#8203;5369](https://github.com/rectorphp/rector-src/pull/5369)) - \[Php55] Handle crash after exit() on GetCalledClassToSelfClassRector ([#&#8203;5372](https://github.com/rectorphp/rector-src/pull/5372)) - \[CodeQuality] Skip method call on else on TernaryFalseExpressionToIfRector ([#&#8203;5373](https://github.com/rectorphp/rector-src/pull/5373)) - Remove return type in case of never in RemoveUselessReturnTagRector ([#&#8203;5323](https://github.com/rectorphp/rector-src/pull/5323)), Thanks [@&#8203;staabm](https://github.com/staabm)! - \[DeadCode] Remove unused [@&#8203;return](https://github.com/return) mixed on RemoveUselessReturnTagRector ([#&#8203;5332](https://github.com/rectorphp/rector-src/pull/5332)) - \[DeadCode] Skip has parent class with \__call() magic method on RemoveParentCallWithoutParentRector ([#&#8203;5336](https://github.com/rectorphp/rector-src/pull/5336)) - \[PHP 5.5] Remove extra preslash in class reference, as in practice removal manually ([#&#8203;5338](https://github.com/rectorphp/rector-src/pull/5338)) - \[DeadCode] Remove null as never used param type in RemoveUselessParamTagRector ([#&#8203;5348](https://github.com/rectorphp/rector-src/pull/5348)) - **Remove json throw on error rule from PHP 7.3 set, as changed behavior and must be applied on purpose** ([#&#8203;5349](https://github.com/rectorphp/rector-src/pull/5349)) - \[Testing] Remove unnecessary set Parameter Source on TestingParser ([#&#8203;5371](https://github.com/rectorphp/rector-src/pull/5371)) ### [`v0.18.12`](https://github.com/rectorphp/rector/releases/tag/0.18.12): Released Rector 0.18.12 [Compare Source](https://github.com/rectorphp/rector/compare/0.18.11...0.18.12) #### New Features :partying_face: - \[CodeQuality] Add RemoveUselessIsObjectCheckRector ([#&#8203;5316](https://github.com/rectorphp/rector-src/pull/5316)) - \[PHP83] Implements a rule to add types to class constants ([#&#8203;5290](https://github.com/rectorphp/rector-src/pull/5290)), Thanks [@&#8203;peterfox](https://github.com/peterfox)! <br> #### Bugfixes :bug: - \[TypeDeclaration] Skip iterable already there in AddReturnTypeDeclarationFromYieldsRector ([#&#8203;5291](https://github.com/rectorphp/rector-src/pull/5291)) - \[TypeDeclaration] Remove ParamTypeFromStrictTypedPropertyRector as seems similar feature with AddParamTypeFromPropertyTypeRector ([#&#8203;5293](https://github.com/rectorphp/rector-src/pull/5293)) - \[CodingStyle] Remove AddArrayDefaultToArrayPropertyRector as based on docblock types and public contract, better use type declaration set instad ([#&#8203;5298](https://github.com/rectorphp/rector-src/pull/5298)) - \[TypeDeclaration] Skip return void in abstract empty class in AddVoidReturnTypeWhereNoReturnRector ([#&#8203;5311](https://github.com/rectorphp/rector-src/pull/5311)) - \[Php80] Skip PDO::query() on AddParamBasedOnParentClassMethodRector ([#&#8203;5313](https://github.com/rectorphp/rector-src/pull/5313)) - \[TypeDeclaration] Add If else assign support on TypedPropertyFromAssignsRector ([#&#8203;5314](https://github.com/rectorphp/rector-src/pull/5314)) - \[CodeQuality] Make CommonNotEqualRector skip if not <> ([#&#8203;5292](https://github.com/rectorphp/rector-src/pull/5292)) - \[Naming] Skip singularize "cms" on RenameForeachValueVariableToMatchExprVariableRector ([#&#8203;5294](https://github.com/rectorphp/rector-src/pull/5294)) - \[TypeDeclaration]\[Performance] Check typed param already early on ParamTypeByMethodCallTypeRector ([#&#8203;5295](https://github.com/rectorphp/rector-src/pull/5295)) - \[Strict] Fix DisallowedEmptyRuleFixerRector empty() allow string '0' check ([#&#8203;5296](https://github.com/rectorphp/rector-src/pull/5296)) - \[EarlyReturn] Skip duplicating complex expression in ChangeAndIfToEarlyReturnRector ([#&#8203;5301](https://github.com/rectorphp/rector-src/pull/5301)) - \[Scoped] Exclude symfony/console/Debug/CliRequest.php from parallel-lint PHP 7.2 syntax check ([#&#8203;5304](https://github.com/rectorphp/rector-src/pull/5304)) - Skip RenameMethodRector in never ([#&#8203;5305](https://github.com/rectorphp/rector-src/pull/5305)), Thanks [@&#8203;staabm](https://github.com/staabm)! - \[CodeQuality] Skip with else on SimplifyForeachToCoalescingRector ([#&#8203;5307](https://github.com/rectorphp/rector-src/pull/5307)) - \[Doc] Typo fix on sample code documentation on SimplifyForeachToCoalescingRector ([#&#8203;5308](https://github.com/rectorphp/rector-src/pull/5308)) - \[Privatization] Skip call non-private method on non-final class on PrivatizeLocalGetterToPropertyRector ([#&#8203;5309](https://github.com/rectorphp/rector-src/pull/5309)) - \[Privatization] Fix first class callable in PrivatizeLocalGetterToPropertyRector ([#&#8203;5310](https://github.com/rectorphp/rector-src/pull/5310)) - \[TypeDeclaration] Keep constant false return type from strict native call ([#&#8203;5223](https://github.com/rectorphp/rector-src/pull/5223)), Thanks [@&#8203;tomi85](https://github.com/tomi85)! - \[PHP 7.0] Skip mt_rand() replacement as not valuable ([#&#8203;5315](https://github.com/rectorphp/rector-src/pull/5315)) - \[Strict] Allow check '0' empty zero on BooleanInTernaryOperatorRuleFixerRector on string type ([#&#8203;5297](https://github.com/rectorphp/rector-src/pull/5297)) - Fix annotation to attribute parsing string ([#&#8203;5317](https://github.com/rectorphp/rector-src/pull/5317)) - \[Instanceof] Fix combination of dead instance and compare ([#&#8203;5319](https://github.com/rectorphp/rector-src/pull/5319)) - Remove isPositiveInteger() check for third argument to strpos() ([#&#8203;5257](https://github.com/rectorphp/rector-src/pull/5257)), Thanks [@&#8203;ikari7789](https://github.com/ikari7789)! - Remove return type in case of void in RemoveUselessReturnTagRector ([#&#8203;5318](https://github.com/rectorphp/rector-src/pull/5318)) - \[DeadCode] Skip [@&#8203;return](https://github.com/return) never with void on RemoveUselessReturnTagRector ([#&#8203;5320](https://github.com/rectorphp/rector-src/pull/5320)) - \[DeadCode] Remove useless nullable [@&#8203;return](https://github.com/return) doc on RemoveUselessReturnTagRector ([#&#8203;5321](https://github.com/rectorphp/rector-src/pull/5321)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 7am" (UTC), Automerge - "before 7am" (UTC). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTguMyIsInVwZGF0ZWRJblZlciI6IjM3LjQxOC4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
renovate added 1 commit 2024-06-27 05:01:10 +02:00
Update dependency rector/rector to ^0.19
Some checks failed
renovate/artifacts Artifact file update failure
e235760f36
renovate scheduled this pull request to auto merge when all checks succeed 2024-06-27 05:01:10 +02:00
renovate force-pushed renovate/rector-rector-0.x from e235760f36 to 4d719693d6 2024-06-27 13:30:55 +02:00 Compare
trizz merged commit 4d719693d6 into main 2024-06-27 13:43:21 +02:00
trizz deleted branch renovate/rector-rector-0.x 2024-06-27 13:43:21 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
renovate trizz
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trizz/adventofcode#9
No description provided.
Delete Branch "renovate/rector-rector-0.x"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?